✨ FormButton の構造を変えて新たな状態を追加 #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4146-prod.traq-preview.trapti.tech/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mehm8128
approved these changes
Nov 11, 2023
| @@ -23,7 +23,7 @@ | |||
| </content-editor> | |||
| </sidebar-content-container-foldable> | |||
| <div :class="$style.item"> | |||
| <form-button label="削除" color="error" @click="deleteClip" /> | |||
| <form-button label="削除" is-danger @click="deleteClip" /> | |||
There was a problem hiding this comment.
ここtype="secondary"つけ忘れてそうです？意図的なら大丈夫です
There was a problem hiding this comment.
変更し忘れです 🙏
修正しました :arigataya:
mehm8128
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
設定画面の改修にあたって、中が塗られた赤いボタンを追加
それに伴って、FormButton の variant を変える手段を
color: 'primary' | 'secondary' | 'tertiary' | 'danger'で指定していたのを、添付画像のようにtype: 'primary' | 'secondary' | 'tertiary'とisDanger: booleanで指定するように(以前の
color: 'secondary',color: 'tertiary'がそれぞれtype: 'tertiary',type: 'secondary'に対応しているので注意)経緯とかは https://q.trap.jp/messages/84c7491d-6470-4a37-834a-cff4feea3ec4 以下にあります