チャンネル選択のドロップダウンからアーカイブチャンネルを削除 #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4257-prod.traq-preview.trapti.tech/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4257 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 66 66
Lines 4722 4722
Branches 565 565
=======================================
Hits 4078 4078
Misses 638 638
Partials 6 6 ☔ View full report in Codecov by Sentry. |
mehm8128
reviewed
Apr 5, 2024
There was a problem hiding this comment.
#3285 (comment)
で懸念点書いてたのですが大きな問題でもないので、使いやすさ重視でこの変更方針で問題ないと思います
| const { channelOptions: rawChannelOptions } = useChannelOptions( | ||
| rootChannel, | ||
| undefined, | ||
| true |
There was a problem hiding this comment.
アーカイブされたチャンネルの子にチャンネル生やすことってなさそうなのでfalseでよさそうです
| @@ -45,7 +45,7 @@ const homeChannelId = computed(() => detail.value?.homeChannel ?? nullUuid) | |||
| const { fetchChannels } = useChannelsStore() | |||
| // 投稿先チャンネルとメッセージでの置換に必要 | |||
| fetchChannels() | |||
| const { channelOptions } = useChannelOptions('-----') | |||
| const { channelOptions } = useChannelOptions('-----', undefined, true) | |||
There was a problem hiding this comment.
アーカイブされたチャンネルには投稿できないのでfalseでよさそうです
|
あ、これ勝手にマージしちゃってOKです |
|
わかりました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
作れそうだったので作ったのですが、元issueで方針も決まっていませんし却下してくださっても大丈夫です