Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picaを使用しないようにして、iOSでの処理の分岐をやめた #4382

Merged
merged 3 commits into from
Oct 24, 2024
Merged

picaを使用しないようにして、iOSでの処理の分岐をやめた #4382

merged 3 commits into from
Oct 24, 2024

Conversation

nokhnaton
Copy link
Contributor

@nokhnaton nokhnaton commented Oct 23, 2024 •
edited
Loading

fix: #4302

@github-actions GitHub Actions
Copy link

Preview (prod) → https://4382-prod.traq-preview.trapti.tech/
Preview (dev) → https://4382-dev.traq-preview.trapti.tech/

Pugma
Pugma approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました！
よさそうです

今回修正されたトリガーについてはこれで大丈夫だと思うんですが、そもそもリサイズの基準が縦横の長さの絶対値で決まってそうで、面積とか画像サイズ基準じゃなさそうです
この辺りについてはどこかで見直したほうがよさそうだと感じています
ただ、これがどれほどうまくいきそうかも見当がつかないので一応ご意見を伺っておきたいです

@nokhnaton nokhnaton merged commit bce3525 into master Oct 24, 2024
9 checks passed
@nokhnaton nokhnaton deleted the feat/fix_image_resizer branch October 24, 2024 15:06
@nokhnaton
Copy link
Contributor Author

#4388 建てました～

@nokhnaton nokhnaton mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pugma Pugma Pugma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOSでアップロードできる画像の画素数の上限をなくす
2 participants
@nokhnaton @Pugma