Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
引用の日付をメッセージのものと合わせるように #4385
引用の日付をメッセージのものと合わせるように #4385
Changes from 1 commit
775645b
b500766
c8d6761
1af8958
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現状はcreatedAtとupdatedAtのうち片方しか使われない(制御結合)形になっているんですが、↓のようにどちらを使うかは外側で決めて変換には必要な日付のみを渡す(データ結合)方がモジュール結合度が低くて運用しやすいんじゃないかなって思います
つまりはgetDisplayDateは消してgetDateRepresentationを広く使いたいねって話です(関数名はgetDisplayDateでもいいんですが)
traQ_S-UI/src/components/Main/CommandPalette/SearchResultMessageElement.vue
Lines 85 to 96 in c8d6761
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あー、確かにこんな感じの使い方がありえるならgetDateRepresentationを広く使う方が良さそうですね