Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make util.BuildControllerOwnerRef behave the same as metav1.NewControllerRef #40

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Make util.BuildControllerOwnerRef behave the same as metav1.NewControllerRef #40

merged 1 commit into from
Jun 29, 2023

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Jun 29, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR makes the original util.BuildControllerOwnerRef behave the same as metav1.NewControllerRef, which includes below changes:

  • controller owner ref would block owner deletion
  • the new function would return a pointer

@zqzten zqzten added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 29, 2023
@zqzten zqzten added this to the v0.2 milestone Jun 29, 2023
@zqzten zqzten requested a review from dayko2019 June 29, 2023 06:47
dayko2019
dayko2019 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@dayko2019 dayko2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayko2019 dayko2019 merged commit fe1730a into traas-stack:main Jun 29, 2023
@zqzten zqzten deleted the controller_ref_tweak branch June 29, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayko2019 dayko2019 dayko2019 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@zqzten @dayko2019