Expose the unified metric provider interface as a service #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayko2019
added
kind/feature
dayko2019
force-pushed
the
metric_server
branch
2 times, most recently
from
c3e03f2
to
bddb38d
Compare
zqzten
requested changes
Aug 8, 2023
dayko2019
force-pushed
the
metric_server
branch
from
bddb38d
to
5c044a6
Compare
zqzten
requested changes
Aug 15, 2023
dayko2019
force-pushed
the
metric_server
branch
from
5c044a6
to
fde2842
Compare
zqzten
requested changes
Sep 3, 2023
dayko2019
force-pushed
the
metric_server
branch
from
fde2842
to
1e9d589
Compare
zqzten
requested changes
Sep 4, 2023
dayko2019
force-pushed
the
metric_server
branch
from
1e9d589
to
516a843
Compare
zqzten
requested changes
Sep 4, 2023
dayko2019
force-pushed
the
metric_server
branch
from
516a843
to
61e2ec1
Compare
zqzten
requested changes
Sep 4, 2023
dayko2019
force-pushed
the
metric_server
branch
from
61e2ec1
to
2a50786
Compare
zqzten
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
/kind dependencies
What this PR does / why we need it:
This enables external algorithm jobs to utilize the internal unified metric provider interface so that they don't need to impl metrics query themselves.
Which issue(s) this PR fixes:
Fixes #39
Special notes for your reviewer: