Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algo: Support custom worker num of data loader of TSF & improve error handling of RE #71

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Algo: Support custom worker num of data loader of TSF & improve error handling of RE #71

merged 3 commits into from
Oct 20, 2023

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Oct 19, 2023

What type of PR is this?

/kind feature
/kind algorithm

What this PR does / why we need it:

This PR:

  1. Supports custom worker num of data loader of time series forecasting. This enables user to set suitable num_workers for their run env.
  2. Improves error handling of replicas estimation. This makes the errors more user friendly.

@zqzten
algo: remove redundant train main in forecaster
f2efe63 
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten
algo: support custom worker num for data loader of tsf
dfe95ad 
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten
algo: improve error handling of re
cf38870 
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten zqzten added kind/feature Categorizes issue or PR as related to a new feature or enhancements of an existing feature. kind/algorithm Categorizes issue or PR as related to algorithm. labels Oct 19, 2023
@zqzten zqzten added this to the v0.2 milestone Oct 19, 2023
@zqzten zqzten requested a review from dayko2019 October 19, 2023 16:49
@zqzten zqzten changed the title Algo: Support custom worker num of data loader of tsf & improve error handling of re Algo: Support custom worker num of data loader of TSF & improve error handling of RE Oct 19, 2023
dayko2019
dayko2019 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@dayko2019 dayko2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayko2019 dayko2019 merged commit c34636d into traas-stack:main Oct 20, 2023
2 checks passed
@zqzten zqzten deleted the algo branch October 21, 2023 15:42
@zqzten zqzten modified the milestones: v0.2, algorithm-v0.1 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayko2019 dayko2019 dayko2019 approved these changes

Assignees
No one assigned
Labels
kind/algorithm Categorizes issue or PR as related to algorithm. kind/feature Categorizes issue or PR as related to a new feature or enhancements of an existing feature.
Projects
None yet
Milestone
algorithm-v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zqzten @dayko2019