efinix: add spiOverJtag support for Ti180J484 #481
Conversation
src/efinix.cpp
Outdated
| uint32_t timeout = 1000; | ||
| _spi->gpio_clear(_rst_pin); | ||
|
|
||
| return reinterpret_cast<SPIInterface *>(_spi)->detect_flash(); |
There was a problem hiding this comment.
Compared to dumpFlash here the FPGA isn't reseted after, no?
There was a problem hiding this comment.
Have you tested this method in SPI mode?
There was a problem hiding this comment.
I confess I have not tried this in anything other than SoJ mode -- my Ti180 board only supports JTAG. Indeed, it does not reset the FPGA afterwards, I think (unless post_flash_access does that?). Looks like I copied this from dumpFlash. Maybe both dumpFlash and this should be refactored to call reset(), which does the same thing? Though as mentioned, I cannot test that on my board, so either way, I would be implementing it blind.
There was a problem hiding this comment.
I've updated this to disallow that path entirely until someone gets to test it.
…ne tries it out for sure
|
Applied. Thanks @jwise ! |
while we are in here, beef up the existing efinix.cpp to be able to detect_flash and dump_flash via SoJ, too