Add Scala 3 build #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Scala, replace single Show instance derived via kittens with manual one. Needs a Scala 3-compatible build of trace4cats core and http4s components.
catostrophe
approved these changes
Jul 28, 2021
catostrophe
reviewed
Jul 28, 2021
|
@ybasket thanks for this. There are a few issues. Let me know if you can handle them. Or I can fix them myself. |
I must have somehow forgotten to compile the tests…thank you for taking care, looks good and CI is happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Scala 3, replace single
Showinstance derived via kittens with manual one. Needs a Scala 3-compatible build of trace4cats core and http4s components, see trace4cats/trace4cats#587