Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): Share some properties across workspace #1039

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Dec 1, 2023

I noticed version bumping touches many places, this is an attempt to alleviate that a bit.

@dcvz dcvz marked this pull request as ready for review December 1, 2023 23:06
@dcvz
Copy link
Contributor Author

dcvz commented Dec 1, 2023

@louisfd doesn't fully centralize version (because of inter deps), but should help already a bit

@nathanielsimard
Copy link
Member

@dcvz This is a great idea! I guess you should update with main and use 0.12.0 instead of 0.11.0, the flaky tests are supposed to be gone.

dcvz added 2 commits December 4, 2023 20:11
# Conflicts:
#	backend-comparison/Cargo.toml
#	burn-autodiff/Cargo.toml
#	burn-candle/Cargo.toml
#	burn-common/Cargo.toml
#	burn-compute/Cargo.toml
#	burn-core/Cargo.toml
#	burn-dataset/Cargo.toml
#	burn-derive/Cargo.toml
#	burn-fusion/Cargo.toml
#	burn-import/Cargo.toml
#	burn-import/onnx-tests/Cargo.toml
#	burn-ndarray/Cargo.toml
#	burn-no-std-tests/Cargo.toml
#	burn-tch/Cargo.toml
#	burn-tensor-testgen/Cargo.toml
#	burn-tensor/Cargo.toml
#	burn-train/Cargo.toml
#	burn-wgpu/Cargo.toml
#	burn/Cargo.toml
#	examples/custom-renderer/Cargo.toml
#	examples/custom-training-loop/Cargo.toml
#	examples/custom-wgpu-kernel/Cargo.toml
#	examples/guide/Cargo.toml
#	examples/image-classification-web/Cargo.toml
#	examples/mnist-inference-web/Cargo.toml
#	examples/mnist/Cargo.toml
#	examples/named-tensor/Cargo.toml
#	examples/onnx-inference/Cargo.toml
#	examples/text-classification/Cargo.toml
#	examples/text-generation/Cargo.toml
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9f93d3) 85.55% compared to head (b6b02ce) 85.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   85.55%   85.58%   +0.02%     
==========================================
  Files         508      508              
  Lines       53910    53910              
==========================================
+ Hits        46122    46138      +16     
+ Misses       7788     7772      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcvz
Copy link
Contributor Author

dcvz commented Dec 4, 2023

@nathanielsimard updated!

@nathanielsimard nathanielsimard merged commit 71d3c1d into tracel-ai:main Dec 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants