-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Move burn crates to their own crates directory #1336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
==========================================
- Coverage 84.49% 78.77% -5.72%
==========================================
Files 571 551 -20
Lines 63818 61836 -1982
==========================================
- Hits 53923 48712 -5211
- Misses 9895 13124 +3229 ☔ View full report in Codecov by Sentry. |
58a81f2
to
9c61841
Compare
9c61841
to
8da91f9
Compare
Fantastic! Perhaps we can add members = [
"crates/*",
] to the main I was wondering if it would be clearer to move |
8da91f9
to
b77184a
Compare
I updated the Cargo file with We have no mechanism to publish examples alongside versions and they are using local crates from the repo. So for now it is better to keep them in the monorepo. |
I would add we should keep in the same repository. It would be difficult to synchronize the versions |
To synchronize the versions we just have to change from |
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Fixes #1263
Changes
Move all the burn crates to their dedicated directory called
crates
.We chose to keep the crate folder names to be the same as the actual crate name, see discussed in #1263
I'll update the links in the contributor book once this is merged.
Testing
run-checks
and making sure our CI passes.