Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX Tile operation #2092

Merged
merged 25 commits into from
Aug 7, 2024
Merged

ONNX Tile operation #2092

merged 25 commits into from
Aug 7, 2024

Conversation

mepatrick73
Copy link
Contributor

@mepatrick73 mepatrick73 commented Aug 3, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Implementing the ONNX Tile operator as well as the corresponding node in the burn graph

Testing

Unit test to make sure Codegen works as intended aswell as the respective end to end test as described in the onnx-tests README.md

@antimora antimora changed the title Onnx tile ONNX Tile operation Aug 5, 2024
@@ -0,0 +1,71 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line in the beginning/.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.29%. Comparing base (e394853) to head (9f6cb4f).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-import/src/burn/node/tile.rs 98.36% 1 Missing ⚠️
crates/burn-import/src/onnx/op_configuration.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
+ Coverage   86.27%   86.29%   +0.01%     
==========================================
  Files         693      694       +1     
  Lines       88888    88990     +102     
==========================================
+ Hits        76691    76791     +100     
- Misses      12197    12199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mepatrick73 mepatrick73 marked this pull request as ready for review August 6, 2024 21:13
@mepatrick73 mepatrick73 requested a review from antimora August 6, 2024 21:13
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for enhancing ONNX ops.

@mepatrick73 mepatrick73 merged commit d770b1f into main Aug 7, 2024
15 checks passed
@mepatrick73 mepatrick73 deleted the onnx-tile branch August 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants