Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/onnx import tanh #683

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Feat/onnx import tanh #683

merged 7 commits into from
Aug 25, 2023

Conversation

AuruTus
Copy link
Contributor

@AuruTus AuruTus commented Aug 24, 2023

Pull Request Template

Checklist

  • Confirm that run-checks script has been executed.

Related Issues/PRs

Solve tanh task #600

Changes

add new unary node tanh to import ONNX model.

Testing

add new test entry under tests/onnx_tests.rs and pass.

@AuruTus AuruTus marked this pull request as ready for review August 24, 2023 10:02
antimora
antimora requested changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this op. There are a couple straight forward additions I am requesting. Please see my inline comments.

burn-import/onnx-tests/tests/tanh/tanh.py Show resolved Hide resolved
burn-tensor/src/tensor/activation/base.rs Show resolved Hide resolved
nathanielsimard
nathanielsimard requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the duplicated test, but other than that LGTM

burn-tensor/src/tensor/activation/base.rs Show resolved Hide resolved
antimora
antimora approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you have a chance to update the readme file by checking off Tanh, it'd be great.

Approving ahead.

@nathanielsimard nathanielsimard merged commit 3fdfeea into tracel-ai:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antimora antimora antimora approved these changes

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AuruTus @antimora @nathanielsimard