Add ui/metrics feature flags #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
requested changes
Aug 31, 2023
There was a problem hiding this comment.
See my comments bellow. Having a cli feature flag is fine, but I would enable it by default. Also we should have a better implementation without using text-plot, probably using something like ratatui: https://github.com/ratatui-org/ratatui.
antimora
requested changes
Aug 31, 2023
dae
changed the title
nathanielsimard
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Thanks @dae I'm still unsure about the feature flag names metrics and ui, but at least we offer the option now!
Partially implements tracel-ai#729: - Added a new train-cli feature to enable the metric plotting/CLI rendering.
|
Conflicts fixed . No preferences on names - some other ideas: train-tui, train-sys-metrics. |
nathanielsimard
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #729:
The burn crate no longer enables the training module unless the train feature is enabled.textplots has two security warnings that can be avoided when the CLI
is excluded:
33 │ atty 0.2.14 registry+https://github.com/rust-lang/crates.io-index
│ ----------------------------------------------------------------- unsound advisory detected
│
= ID: RUSTSEC-2021-0145
= Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0145
= On windows,
attydereferences a potentially unaligned pointer.16 │ ansi_term 0.12.1 registry+https://github.com/rust-lang/crates.io-index
│ ---------------------------------------------------------------------- unmaintained advisory detected
│
= ID: RUSTSEC-2021-0139
= Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0139
= The maintainer has advised that this crate is deprecated and will not receive any maintenance.
Pull Request Template
Checklist
run-checksscript has been executed.Related Issues/PRs
#729