Re-export some submodules and add feature flags for them #759
Conversation
I'm not sure why, but the previous commit has caused this doctest to break: ---- burn-core/src/module/base.rs - module::base::Module (line 76) stdout ---- Test executable failed (exit status: 127). stderr: /tmp/rustdoctestUn8l2X/rust_out: error while loading shared libraries: libtorch_cpu.so: cannot open shared object file: No such file or directory When invoked via: cargo test -p burn-core --features test-tch,tch Tch does still appear to work when running one of the examples
There was a problem hiding this comment.
This is pretty much what I had in mind! I'm still unsure if the backend module and the autodiff re-export should be implemented in burn-core vs in burn. It might reduce the number of feature flags duplication, but won't change the end-user API.
@dae Let me know what you think is the better way, I don't have a strong preference.
examples/guide/examples/guide.rs
Outdated
| type MyBackend = WgpuBackend; | ||
| type MyAutodiffBackend = WgpuAutodiffBackend; |
There was a problem hiding this comment.
For this example, let's keep the generics. It's documented this way in the guide and shows how to set the element types! But having defaults is indeed convenient.
|
Because of the fact that burn-core is already using autodiff and already has the test-{backend} flags, it seems easier to keep the current setup despite the extra boilerplate routing the settings - at least it's consistent with the other exports like dataset that way. In the longer term it might be worth revisiting the crate layout - if burn-core focused on only stuff that needed to be shared between the different subcrates (or perhaps were merged into burn-common), that would make things a bit simpler when navigating around the packages. |
Pull Request Template
Implements some of the suggestions from #729. I think the type aliases will be useful for people new to Burn, but happy to cut them or move them if you prefer.
Is this the direction you were hoping to go with the meta crate?
Checklist
run-checksscript has been executed.