Implementing ONNX support for sqrt #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antimora
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Looks great!
One small change requested in the supported ops: to replace X with a check mark:
https://github.com/Tracel-AI/burn/blob/main/burn-import/SUPPORTED-ONNX-OPS.md?plain=1#L181
Once this is done, it's approved.
Fixed with 02b3ecb |
antimora
approved these changes
Nov 22, 2023
|
All green. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Addresses #600 SQRT operator.
ONNX validity has been confirmed using Neutron, see
Checklist
run-checks allscript has been executed.Testing
cargo testin theburn-importsubpackage