Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI checks only one version of the bindings #4

Closed
VlaDexa opened this issue Nov 28, 2024 · 2 comments
Closed

CI checks only one version of the bindings #4

VlaDexa opened this issue Nov 28, 2024 · 2 comments

Comments

@VlaDexa
Copy link
Contributor

VlaDexa commented Nov 28, 2024

If you're planning to maintain bindings for more than one version, this CI configuration won't really work well, because it only checks the version that is configured.

@syl20bnr
Copy link
Member

Indeed you are right.
To keep things simple and keep the CI as it is I will match the version of the crate with the version with HIP and we put the corresponding HIP version to the default feature. People will be able to downgrade by either ignore the default feature and add an earlier one or just change the crate version.

@syl20bnr
Copy link
Member

syl20bnr commented Dec 3, 2024

I released the new version scheme and updated the README.
Basically the crate follows the version of the default bindings but the patch version is multiplied by 1000 so it leaves room to make several releases with the same default bindings version.

@syl20bnr syl20bnr closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants