Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ROCm v6.2.4 #2

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Update to ROCm v6.2.4 #2

merged 2 commits into from
Dec 3, 2024

Conversation

VlaDexa
Copy link
Contributor

@VlaDexa VlaDexa commented Nov 26, 2024

I think tests for this are kinda non existent at this moment, so it only ran one.

Running unittests src/lib.rs (target/debug/deps/cubecl_hip_sys-bc038986488f0a05)

running 1 test
test tests::test_launch_kernel_end_to_end ... ok

Also your suggested test command cargo xtask test --features rocm_622 wouldn't work on any other feature, like mine (rocm_624), because rocm_622 is set by default, and it name-clashes with the other version. That's also why I put 6.2.4 in the default.

@VlaDexa
Copy link
Contributor Author

VlaDexa commented Nov 28, 2024

With the change to CI, it will check correctness only of the latest rocm binding, which may be undesired. I've opened issue #4 for discussion of this problem.

@syl20bnr
Copy link
Member

syl20bnr commented Dec 3, 2024

Thank you !
I am going to update the versioning scheme and the README accordingly.

@syl20bnr syl20bnr merged commit 3fc3c1a into tracel-ai:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants