Fix incorrect cargo instruction invocation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VlaDexa
force-pushed
the
fix-cargo-instructions
branch
from
ad7e449 to
0d587e1
Compare
VlaDexa
force-pushed
the
fix-cargo-instructions
branch
from
0d587e1 to
c7f0c10
Compare
syl20bnr
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Nice catch!
I made some changes to use the crate feature instead of the cargo env vars of the crate so you need to rebase on the last changes.
I changed the feature naming scheme so that it is easier to parse. Also I mapped the header patch version to the rocm official released version. Note that I might make some other tweaks given the answer in this issue: ROCm/HIP#3703
|
I actually resolved the conflict so that I can re-release the versions... 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo instructions use
cargo::, with two:https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script