Feat/cli first version #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
… for now) Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
There are some problems with running with multiple config files with Heat for now. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Which allows for specifying json config files to run a experiment training with. Co-authored-by: Thierry Cantin-Demers <ThierryCantin-Demers@users.noreply.github.com>
Added support for inference macro.
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwrichard26@gmail.com>
Experiment can now be run from crate from CLI. General cleanup of macros. Only generate macros when necessary. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Seems to be a little untable when using multiple backends at the same time. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Moved codegen to crate gen (mostly). Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
to prevent building heat-sdk-cli when building second cli
Organized crate generation in structs Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
…code. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
better encapsulation for cli context, removed most getters and setters
ThierryCantin-Demers
changed the title
syl20bnr
approved these changes
Aug 14, 2024
| args: LocalTrainingRunArgs, | ||
| mut context: HeatCliContext, | ||
| ) -> anyhow::Result<()> { | ||
| // print all functions that are registered as training functions |
There was a problem hiding this comment.
Maybe create functions for the display of registered flags, the check of functions, the run loop etc...
| function: String, | ||
| config_path: String, | ||
| project: String, | ||
| key: String, |
There was a problem hiding this comment.
Maybe declare a struct for this since there is already 4 fields ?
| } | ||
|
|
||
| /// Returns the backend type names for the given procedure type. | ||
| /// Ex: For ProcedureType::Training, the backend type name will be MyTrainingBackend and autodiff backend type name will be MyTrainingAutodiffBackend. |
There was a problem hiding this comment.
Not sure that the comment is up to date
|
Let's merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a first version of the heat sdk CLI, easy to integrate into the user's project with a few macros. The CLI can currently: