Heat CLI project packaging and publishing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
… for now) Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
There are some problems with running with multiple config files with Heat for now. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Which allows for specifying json config files to run a experiment training with. Co-authored-by: Thierry Cantin-Demers <ThierryCantin-Demers@users.noreply.github.com>
Added support for inference macro.
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwrichard26@gmail.com>
Experiment can now be run from crate from CLI. General cleanup of macros. Only generate macros when necessary. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Seems to be a little untable when using multiple backends at the same time. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Moved codegen to crate gen (mostly). Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
to prevent building heat-sdk-cli when building second cli
Organized crate generation in structs Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
…code. Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
better encapsulation for cli context, removed most getters and setters
…cargo pushing this as a backup for now Co-authored-by: Thierry Cantin-Demers <ThierryCantin-Demers@users.noreply.github.com>
Co-authored-by: Thierry Cantin-Demers <ThierryCantin-Demers@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
jwric
changed the title
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
|
too big to review, but a demo would be cool soon @ThierryCantin-Demers |
syl20bnr
requested changes
Aug 29, 2024
There was a problem hiding this comment.
I skimmed through it and it looks fine to me.
The temp json file seems to be unused.
It is not ideal to import thousands of cargo lines of code as it is not easy to maintain and keep it in sync with upstream but the code of cargo is pretty mature already so I guess we are fine for quite some time.
Can you add a header comment that points to the original source files in github for each imported source file ?
Also can you add comments around the modifications you have made when possible with something like:
// --- Start Tracel modifications ---
...
// --- End Tracel modifications ---
crates/tracel/temp.json
Outdated
| @@ -0,0 +1,830 @@ | |||
| { | |||
There was a problem hiding this comment.
This file seems to not be used anywhere.
There was a problem hiding this comment.
Oh right, it was the output of a cargo metadata that we forgot to remove. Removing it now.
| @@ -0,0 +1,13 @@ | |||
| //! All of the code in this directory is heavily inspired by the [Cargo source code](https://github.com/rust-lang/cargo) | |||
| //! and modified to fit the needs of the heat-sdk-cli project. | |||
There was a problem hiding this comment.
Great that you thought about adding this.
Can you go more into details about the modifications you have made in this source code as well in this comment ?
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds crate based project packaging and uploading to the Heat backend, aswell as queueing a job for the new runner service.
Closes #26