Move Array#fill to "write then read" methods so the template correctly updates #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@locks might be worth adding a simple test so we don’t regress in the future? |
acorncom
reviewed
Sep 20, 2023
test-app/tests/unit/array-test.ts
Outdated
| @@ -49,7 +49,7 @@ const ARRAY_SETTER_METHODS = [ | |||
| // vice versa). | |||
| expectTypeOf<TrackedArray<unknown>>().toMatchTypeOf<Array<unknown>>(); | |||
|
|
|||
| module('TrackedArray', function (hooks) { | |||
| module.only('TrackedArray', function (hooks) { | |||
|
The test failures on newer ember versions are because we need some blueprint updates. Working on that here: #409 |
|
If you rebase on master now tests should be passing. |
|
Thank you for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
Array#fillto showcase how to useTrackedArrayand the template was not updating accordingly.