feat: fix set issues for TypeScript 5.5+

[chrisvdp]

#417

This fixes the issues introduces in Typescript 5.5 by updating the types used in Map and Set and implementing the new properties on Set.

This is a breaking change and would require users to be on Typescript 5.5+.

[chrisvdp]

not sure if this should be added here, but it was the only way to get the errors to show properly when developing and adding tests.

[SergeAstapov]

Thank you @chrisvdp for contribution! Could you please fix lint errors?

[chrisvdp]

@SergeAstapov updated with your feedback

[chrisvdp]

@SergeAstapov I seem to have run into an issue with typescript-eslint and TS version support.

It seems that 5.6 was added in version 8.10, but that requires an overhaul to eslint configs in general. typescript-eslint/typescript-eslint#9653

5.5 support was added in v7.14.1.

Downgrading the version of TS here to 5.5 to avoid the eslint upgrade.

[chrisvdp]

It seems to be upset about this line https://github.com/tracked-tools/tracked-built-ins/pull/421/files#diff-4675cdfe75e78e757eea8a2f32008948d1713d77a78e3dff46f8dec79f297305L214

but I'm not sure it can be removed or why it's there

[chrisvdp]

minimum required version for TS 5.5

[chrisvdp]

@SergeAstapov should I update the matrix of TS versions this runs against?

https://github.com/tracked-tools/tracked-built-ins/blob/master/.github/workflows/CI.yml#L144

Was thinking along the lines of

ts-version:
          - '5.2'
          - '5.3'
          - '5.4'
          - '5.5'
          - '5.6'
          - 'next'

[SergeAstapov]

@chrisvdp if you don't mind, I would separate infra updates and TS support matrix from this specific fix.

Let me work on bringing CI in this repo to green state and we can get back to this specific fix to ensure we iterate on green CI and do one thing at a time.

[chrisvdp]

@chrisvdp if you don't mind, I would separate infra updates and TS support matrix from this specific fix.

Let me work on bringing CI in this repo to green state and we can get back to this specific fix to ensure we iterate on green CI and do one thing at a time.

Sounds good

[NullVoxPopuli]

#424 should unblock this

[NullVoxPopuli]

this is unblocked!

[chrisvdp]

this is unblocked!

Rebased

[SergeAstapov]

@chrisvdp CI is failing with 5.4 and 5.5, mind to take a look if this can be fixed?

[NullVoxPopuli]

Should we drop support for TS < 5.6?

[chrisvdp]

I think that at least >=5.5 is required as we are adding features added there. I think I can fix the issues with 5.5 by removing some of the explicit return types as they seem to have changed between 5.5 -> 5.6

[chrisvdp]

I pushed a commit that works on 5.5 and 5.6 locally for me

[SergeAstapov]

Should we drop support for TS < 5.6?

fine for me. then, we could drop support for some older Ember.js versions as well to bundle into next major

[SergeAstapov]

I'd like to drop 5.4 support in separate PR so this one would be focused on fixing Set issues

[NullVoxPopuli]

@SergeAstapov here you go: #434

@chrisvdp so so so sorry this has taken so long -- once the above is merged, one last rebase should be all we need <3

[NullVoxPopuli]

we're good to go! @chrisvdp do you happen to have time to rebase?