refactor(strapi/cleanup): cleanup code #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathandebalthasar
changed the base branch from
main
to
refactor!/strapi-integration
nathandebalthasar
merged commit 30c013a
into
refactor!/strapi-integration
2 checks passed
nathandebalthasar
added a commit
that referenced
this pull request
Nov 23, 2023
* refactor!(strapi-implementation): begin of amplify removal * feat(strapi-integration): add StrapiApi class * feat(strapi-implementation): add new types * feat(strapi/search-page): implement the search page (#5) * feat(strapi/playback-page): implement the playback page with Strapi (#6) * feat(strapi/section-page): Implement the section page (#7) * refactor(strapi/genre): comply with the new genre architecture (#9) * refactor(strapi/cleanup): cleanup code (#10) * docs(README): Update README.md (#11) * Refactor/strapi/landing sections (#12) * hotfix(demo): comment unused code * fix(dep): dependencies conflicts in yarn.lock * fix(dep): dependencies conflict in package-lock.json * refactor(cleanup): cleanup code (#13) --------- Co-authored-by: pierreSchrothDev <128720698+pierreSchrothDev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the unused code used for amplify authentication and to contact the GraphQL API also from Amplify which we do not use anymore.