ENH PHP 8.1 compatibility #763
Conversation
| @@ -166,9 +166,9 @@ protected function getRuleController($existingRule, $localeObj) | |||
| */ | |||
| protected function insertRuleBefore(array $rules, $key, array $rule, $prependIfMissing = true) | |||
| { | |||
| $i = array_search($key, array_keys($rules)); | |||
| $i = array_search($key, array_keys($rules ?? [])); | |||
There was a problem hiding this comment.
I assume array param type precludes null values. Is that not true in 8.1 anymore?
There was a problem hiding this comment.
ok, so it's more to do with changes to internal function arguments than typehints, apparently. I think in this case we can rely on the typehint. :)
|
In general, nothing harmful, but lots of unnecessary nullable checks. I can approve if you are ready. |
|
PHP 8.1 throws deprecation warnings if you pass null into non-nullable params on native functions now. A whole lot of fun. Solution was a code writer which does create lots of unnecessary nullable checks. We've done the same on framework and all other supported modules Happy to have approved, though I'd like to keep draft for now and unmerged on the chance that there's something that was missed |
|
@tractorcow This is ready for review now. Thanks. |
|
@tractorcow there's some discussion in silverstripe/silverstripe-admin#1294 about the general approach which may be useful context. |
Issue silverstripe/silverstripe-framework#10250