Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH PHP 8.1 compatibility #5

Merged
merged 1 commit into from
Apr 25, 2022
Merged

ENH PHP 8.1 compatibility #5

merged 1 commit into from
Apr 25, 2022

Conversation

emteknetnz
Copy link
Contributor

@emteknetnz emteknetnz mentioned this pull request Apr 13, 2022
Closed
@emteknetnz emteknetnz marked this pull request as ready for review April 20, 2022 05:11
GuySartorelli
GuySartorelli approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: See discussion in silverstripe/silverstripe-admin#1294 about the general approach. tl;dr:

the purposes of this PR is to avoid passing null (specifically null) from built-in functions that as of php 8.1 will throw deprecation warnings if null is passed in. The approach is necessarily heavy-handed, and while there are many situations where it isn't needed, it would be prohibitively laborious to find all of those situations by hand.

Looks good to me, though I don't have access to merge this one.

@tractorcow tractorcow merged commit 3c05e96 into tractorcow:master Apr 25, 2022
@emteknetnz emteknetnz deleted the pulls/master/php81 branch April 25, 2022 23:46
@tractorcow
Copy link
Owner

I've tagged 1.0.0 fyi

@emteknetnz
Copy link
Contributor Author

@tractorcow any chance you could tag 0.1.3? - proxy-db requires ^0.1.1 https://github.com/tractorcow/silverstripe-proxy-db/blob/master/composer.json

This was referenced Apr 27, 2022
Closed
Merged
@emteknetnz
Copy link
Contributor Author

@tractorcow I've opened up a subsequent pull-request on proxy-db to require ^1 of classproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

@tractorcow tractorcow tractorcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @tractorcow @GuySartorelli