Include shell source and build source directories in proc.Spawn
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to make some changes to initdata for #89, and in the process made it simpler. Now the list of files is in one place, and we always embed them into the bootloader. However, for debug builds we default to embedding just the filepaths instead of their contents, and fetching them at runtime. You still have the option of embedding the file contents by setting the `PROD` environment variable. This supports previous behavior while simplifying the codepaths.
…ctories Closes #88 Closes #89 I though it was a bit silly casting `s.fsys` everywhere, so I modifed `fs.go` to store the `watchfs` seperately. There was also an issue in `wasm.js:writeSync()` where it would be passed a null value for `buf` after the build tool finished in `proc.go:Spawn()`. I added a catch-all fix, but perhaps its a bug that the null is passed in the first place. There's still some kinks to work out before you can edit the shell seamlessly, namely using better heuristics for when files should be updated/rebuilt. We can use mtime/ctime for those.
…`initfs` Closes #66 Enables proper live editing within Wanix! `proc.Spawn` will rebuild commands from source if it's been modified, and `kernel.fs` will copy in `initfs` files if they've been modified externally *(note this will overwrite local files inside Wanix)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89
Closes #88
Closes #66
Live editing is here!
One small footgun: until #69 is completed any errors produced by build in
proc.Spawnwon't be reported to the user.