GitHub Filesystem #105
Merged
GitHub Filesystem #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase off main and mark as not WIP? |
Still WIP. Needed patch the bootloader to ignore nonlocal requests. This is a temporary workaround, in the future we want to make a special endpoint for external requests and monkeypatch fetch to use it for external hostnames.
The filesystem is read only for now, but commands like `ls` and `cat` work great. You'll have to paste your own Github Token in `fs.go`, ideally we can pull this from the shell environment but the shell might not even be compiled by the time `githubfs` is mounted.
Moved `ReadDir` since there's no point in making it a top level func. Enforce using basename for `fileInfo.name` to match the API, added extra branch/path info. This is starting to get messy. After adding directory and write operations I want to review and maybe refactor.
Abstract requesting into it's own function. Implement proper reading/writing instead of reusing the response's `ReadCloser`.
Doesn't support directories or `RemoveAll`, but now you can delete files.
Parzival-3141
force-pushed
the
github-fs
branch
from
8c156fc to
842a838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
TODO:
Create(),Seek(), andWrite()Rename/Remove