New CLI and bootdata system #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
`filepath` package uses different path separators depending on the target OS. On Windows this causes errors since embedFS expects Unix path separators. We should really be using the `path` package everywhere unless specifically interacting with the host OS.
initfs, now bootfs, only contains files necessary to boot the kernel. What is now called initfs will contain userspace files to setup the dev environment. Think of it like GNU CoreUtils, preinstalled on most Unix OSes but unnecessary to actually boot.
This commit makes some changes to the structure of `boot/initfs/` and how initfs files are copied. Instead of hardcoding which files go where, `fs.go` just unpacks the contents of initfs into `/sys/*`. It's basically running the equivalent of: ```sh cd /sys/ && \ get wanix-initfs.gz && \ gzip -d wanix-initfs.gz && \ tar -xf wanix-initfs ``` This gives us direct and simple control of file placement. And if in the future we want to put things outside of `/sys`, we can just unpack to `/` and update the build paths. Though it makes sense to me that initfs would only include system related files.
|
I've updated the PR to fulfill the rest of #138. I made some changes to how |
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a wanix CLI that replaces the dev server and has a command equivalent to our bundle generation command. However, it works much differently. Instead of "bundle" where it assembled the bootloader.js and other files right there, the "loader" command will write files out from embedded data in the binary itself. "Bundling" is now just building the wanix CLI.
The new
bootdir is embedded into the wanix CLI. It contains the bootdata files to bootstrap the wanix kernel, theloader.js, the HTML files needed for a deploy and is a staging directory forkernel.gzandinitfs.gz. Both of those files are created by make.This PR also breaks Wanix because it's incomplete. We still need to alter the kernel to start using the
wanix-initfs.gzfile if/sys/initdoes not exist, and place files from there. This is what's left of #138, which this PR implements a lot of.One thing I didn't do is rename the existing
initfsin the codebase tobootfs.