Use @inlinable and remove redundant helper function
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 24, 2022 16:57
Signed-off-by: Niclas Kristek <dev@nkristek.com>
This allows for better compiler optimisations, since the content of the inlined helper function can be inlined itself, instead of it just being able to be called from within an inlined function. Signed-off-by: Niclas Kristek <dev@nkristek.com>
Signed-off-by: Niclas Kristek <dev@nkristek.com>
nkristek
force-pushed
the
inlinable_and_simplify_code
branch
from
e582a39
to
f54f393
Compare
Marcocanc
approved these changes
Jan 10, 2023
|
@nkristek somehow the Unit Tests aren't running, potentially due to the force push. I also don't have the option to re-run on my end. Could you push something to retrigger the checks? |
added 2 commits
January 10, 2023 16:44
Signed-off-by: Niclas Kristek <dev@nkristek.com>
Signed-off-by: Niclas Kristek <dev@nkristek.com>
|
@Marcocanc could you please retry running the workflow? I've pushed two small commits that improve the description of some error cases. |
Signed-off-by: Niclas Kristek <dev@nkristek.com>
|
I've just noticed, that in the example project the snapshot tests were broken. They're fixed as well now. |
Signed-off-by: Niclas Kristek <dev@nkristek.com>
|
Running now. I also changed the settings so you don't need approval for every run. |
Merged
nkristek
pushed a commit
that referenced
this pull request
Jan 13, 2023
The recent changes may be source breaking, thus the next release needs to be a new major version. Changelog: - Add `MainActor` & `Sendable` annotation to relevant types (#101) - Fix snapshot testing dependency in example project (#102) - Fix Xcode 14 compiler warnings (#103) - Use `@inlinable` and remove redundant helper function (#105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny PR that changes two things:
Dictionary(grouping:by:)instead of the custom implementation that was used previously@inlinableinstead of@usableFromInlineoninternalhelper functions, that are small enough to benefit from inlining. This allows for better compiler optimisations, since the content of the inlined helper function can be inlined itself, instead of it just being able to be called from within an inlined function.Error.moveIsNotInTheSameSectionandError.adapterDoesNotContainSectionController