-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @inlinable
and remove redundant helper function
#105
Use @inlinable
and remove redundant helper function
#105
Conversation
Signed-off-by: Niclas Kristek <dev@nkristek.com>
This allows for better compiler optimisations, since the content of the inlined helper function can be inlined itself, instead of it just being able to be called from within an inlined function. Signed-off-by: Niclas Kristek <dev@nkristek.com>
Signed-off-by: Niclas Kristek <dev@nkristek.com>
e582a39
to
f54f393
Compare
@nkristek somehow the Unit Tests aren't running, potentially due to the force push. I also don't have the option to re-run on my end. Could you push something to retrigger the checks? |
Signed-off-by: Niclas Kristek <dev@nkristek.com>
Signed-off-by: Niclas Kristek <dev@nkristek.com>
@Marcocanc could you please retry running the workflow? I've pushed two small commits that improve the description of some error cases. |
Signed-off-by: Niclas Kristek <dev@nkristek.com>
I've just noticed, that in the example project the snapshot tests were broken. They're fixed as well now. |
Signed-off-by: Niclas Kristek <dev@nkristek.com>
Running now. I also changed the settings so you don't need approval for every run. |
The recent changes may be source breaking, thus the next release needs to be a new major version. Changelog: - Add `MainActor` & `Sendable` annotation to relevant types (#101) - Fix snapshot testing dependency in example project (#102) - Fix Xcode 14 compiler warnings (#103) - Use `@inlinable` and remove redundant helper function (#105)
This is a tiny PR that changes two things:
Dictionary(grouping:by:)
instead of the custom implementation that was used previously@inlinable
instead of@usableFromInline
oninternal
helper functions, that are small enough to benefit from inlining. This allows for better compiler optimisations, since the content of the inlined helper function can be inlined itself, instead of it just being able to be called from within an inlined function.Error.moveIsNotInTheSameSection
andError.adapterDoesNotContainSectionController