Improve performance of reusing SectionControllers by creating temporary dictionary #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the SectionController reusing logic from
O(m * n)
toO(m + n)
.Previously, for every section in the new list, a section with the same id was searched in the old list, meaning the old list was iterated for every item in the new list. Now this PR creates a temporary dictionary which offers constant time lookups and reduces the effort to one iteration of the old list.