Update build scripts to use phpunit/phpcs as a library and more. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer installs dev dependencies by default nowadays.
I've never seen us ignore these editor files before...
This allows phpunit to be run without having to specify the path to the test suite. This is a nicety for users and can help make this play well if we hook it up to scrutinizer.
Rather than executing phpcs via passthru, pull it in as a library. This enables more programmatic access to it.
This enables more programmatic access to phpunit, especially when it comes to code coverage. By using the code coverage report object directly we can remove the clover.xml generation and libxml dependency.
yonderblue
pushed a commit
that referenced
this pull request
Jul 22, 2014
Update build scripts to use phpunit/phpcs as a library and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same standard set of changes I've made elsewhere. Important changes are using phpunit/phpcs as a library, enabling strict code coverage in phpunit, and setting the WORKDIR for the docker build (so you can
docker run -ti -v $(pwd):/code mongo-queue-php composer update, etc.