Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Replace storybook-deployer with github-actions-storybook-to-github-pages #428

Closed
mdeliatf opened this issue Apr 16, 2024 · 0 comments · Fixed by #434
Closed

[Infra] Replace storybook-deployer with github-actions-storybook-to-github-pages #428

mdeliatf opened this issue Apr 16, 2024 · 0 comments · Fixed by #434
Assignees
Labels
area/infrastructure Pull requests that update infra/dependencies kind/bug/fix a bug fix

Comments

@mdeliatf
Copy link
Contributor

Feature request

Overview

While working on #426 and #427 I've noticed We are publishing the Storybook app using @storybook/storybook-deployer.
This project's been archived and forces the usage of npm - not a big problem for us, since the library is still built using yarn, but still a little inconsistency.
Another modern solution, supporting yarn, is available as suggested in the Storybook documentation - please see the link below.

Examples in other libraries

Please see https://storybook.js.org/docs/sharing/publish-storybook#github-pages.

Who does this impact? Who is this for?

Faency maintainers/developers.

@mdeliatf mdeliatf added question Further information is requested area/infrastructure Pull requests that update infra/dependencies labels Apr 16, 2024
@nmengin nmengin added kind/bug/fix a bug fix and removed question Further information is requested labels May 17, 2024
@mdeliatf mdeliatf self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infrastructure Pull requests that update infra/dependencies kind/bug/fix a bug fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants