Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install dev deps on gh actions (part 2) #427

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: install dev deps on gh actions (part 2) #427

merged 2 commits into from
Apr 16, 2024

Conversation

mdeliatf
Copy link
Contributor

Description

This PR fixes some regular dependencies wrongly declared as development, missing from the previous PR.

Preview

No visual changes.

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it 
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf self-assigned this Apr 16, 2024
mloiseleur
mloiseleur approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdeliatf mdeliatf mentioned this pull request Apr 16, 2024
Closed
@mdeliatf mdeliatf marked this pull request as ready for review April 16, 2024 10:17
@traefiker traefiker merged commit 27675eb into traefik:master Apr 16, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

Assignees

@mdeliatf mdeliatf

Labels
kind/bug/fix a bug fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdeliatf @traefiker @mloiseleur