-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kill css incompatible error #294
fix: kill css incompatible error #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some css as any
in a few components, I think with this change we can get rid of them too.
I found occurrences in:
@seedy the build doesn't seem to be working though |
@paulocfjunior build fixed, I added some checks for types everywhere |
560a269
to
72f0329
Compare
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Closes #293
Applies solutions from related issue on stitches.
How to test
Textarea.stories.tsx
had typing issues. I'm taking this one as example, but this PR should fix allcss
typing issues in the project. It would be awesome to validate that point with more use cases.EDIT: I just added stories for
Text
andHeading
showing that we can addcss
prop to those components 🎉Preview
simplescreenrecorder-2022-02-16_20.40.48.mp4