Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kill css incompatible error #294

Merged
merged 9 commits into from
Feb 18, 2022

Conversation

seedy
Copy link
Contributor

@seedy seedy commented Feb 16, 2022

Description

Closes #293

Applies solutions from related issue on stitches.

How to test

Textarea.stories.tsx had typing issues. I'm taking this one as example, but this PR should fix all css typing issues in the project. It would be awesome to validate that point with more use cases.

EDIT: I just added stories for Text and Heading showing that we can add css prop to those components 🎉

  1. Try opening the file without changes applied by my PR. Check you have typescript lint issues in the file
  2. Checkout my PR, make sure you restart you IDE in-between (close/reopen)
  3. Check you no longer have typescript lint issues in the file

Preview

simplescreenrecorder-2022-02-16_20.40.48.mp4

@seedy seedy added kind/bug/fix a bug fix prio This requires urgent handling labels Feb 16, 2022
Copy link

@paulocfjunior paulocfjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some css as any in a few components, I think with this change we can get rid of them too.
I found occurrences in:

  • RadioAccordion: L15
  • Select: L240
  • TextArea: L266 and L273
  • Tooltip: L53 (and in this file, the CSS type is imported from the wrong place, it should come from stitches.config, example)

components/Heading/Heading.stories.tsx Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@seedy seedy requested a review from paulocfjunior February 17, 2022 18:51
@paulocfjunior
Copy link

@seedy the build doesn't seem to be working though

@seedy
Copy link
Contributor Author

seedy commented Feb 17, 2022

@seedy the build doesn't seem to be working though

@paulocfjunior build fixed, I added some checks for types everywhere

@traefiker traefiker force-pushed the fix/kill-css-incompatible-error branch from 560a269 to 72f0329 Compare February 18, 2022 15:02
@traefiker traefiker merged commit 1e20b65 into traefik:master Feb 18, 2022
@traefiker
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/fix a bug fix prio This requires urgent handling released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css types incompatible
4 participants