Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aria-description in SidePanel #5007

Merged

Conversation

mdeliatf
Copy link
Contributor

Description

This PR introduces an optional description property to the SidePanel component for accessibility purposes.

Preview

No visual changes.

Breaking changes

None.

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf requested a review from gndz07 January 21, 2025 15:12
@mdeliatf mdeliatf self-assigned this Jan 21, 2025
@traefiker traefiker merged commit 959de6c into traefik:master Jan 21, 2025
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants