Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Affinity templating and example #557

Merged
merged 2 commits into from
Oct 10, 2022
Merged

💄 Affinity templating and example #557

merged 2 commits into from
Oct 10, 2022

Conversation

MickaelCa
Copy link
Contributor

What does this PR do?

Fix #468

Motivation

We need to have only 1 pod of traefik per node

More

@mloiseleur mloiseleur changed the title add working affinity fix affinity Sep 28, 2022
@mloiseleur mloiseleur mentioned this pull request Sep 28, 2022
Closed
1 task
@mloiseleur mloiseleur added the kind/breaking This PR introduce a breaking change label Sep 28, 2022
@mloiseleur mloiseleur changed the title fix affinity fix: Affinity templating and example Oct 10, 2022
@mloiseleur mloiseleur changed the title fix: Affinity templating and example 💄 Affinity templating and example Oct 10, 2022
@mloiseleur
Copy link
Contributor

mloiseleur commented Oct 10, 2022 •
edited

Hello @MickaelCa,

Thanks for your PR.
I found a way to reach this goal without breaking the format (and so avoid a breaking change for users already using affinity section).
I updated and rebased the PR. Wdyt ?

charlie-haley
charlie-haley approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@charlie-haley charlie-haley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur removed the kind/breaking This PR introduce a breaking change label Oct 10, 2022
@mloiseleur mloiseleur self-assigned this Oct 10, 2022
@mloiseleur mloiseleur merged commit eeba20d into traefik:master Oct 10, 2022
terrych0u pushed a commit to terrych0u/traefik2-helm-chart that referenced this pull request Oct 11, 2022
@MickaelCa @mloiseleur @terrych0u
💄 Affinity templating and example (traefik#557)
c9d1fe7 
* add working affinity

* Rebase and use tpl->toYaml in order to avoid breaking change

Co-authored-by: Michel Loiseleur <michel.loiseleur@traefik.io>
@reitermarkus reitermarkus mentioned this pull request Dec 9, 2022
Closed
@MickaelCa MickaelCa deleted the better-affinity branch March 1, 2023 18:09
@mloiseleur mloiseleur mentioned this pull request Aug 2, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-haley charlie-haley charlie-haley approved these changes

Assignees

@mloiseleur mloiseleur

Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podAntiAffinity example does not work
4 participants
@MickaelCa @mloiseleur @charlie-haley @kevinpollet