Disable http2 connect setting for websocket by default #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
approved these changes
Jan 7, 2025
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes use of the GODEBUG flag
http2xconnectto deactivate the connect setting for HTTP2 by default.Motivation
With the update to
golang.org/x/netv0.33.0 we brought the following changes: https://go-review.googlesource.com/c/net/+/610977It enabled by default the server to answer to be handling connect method for http2 websocket upgrade.
However, this advertisement for this type of upgrade is yet incompatible with
net/httphttp1 reverse proxy. (please see golang/go#71128 (comment)).Fixes #11405
More
Additional Notes
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com
Co-authored-by: Michael michael.matur@gmail.com