Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observability configuration on EntryPoints #11446

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

rtribotte
Copy link
Member

What does this PR do?

This PR fixes the observability configuration on EntryPoints.
This configuration relies on the model mechanism for which its enablement was not yet conditioned to observability configuration on EntryPoints.

Motivation

Fixes #11444

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@rtribotte rtribotte force-pushed the fix-observability-entrypoint-model branch from 5b24ed4 to 1ed7a7b Compare January 14, 2025 09:41
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker
Copy link
Contributor

🚫 checks status: PR status: cancelled

@rtribotte rtribotte force-pushed the fix-observability-entrypoint-model branch from 660882e to a5ced84 Compare January 14, 2025 14:06
@rtribotte rtribotte force-pushed the fix-observability-entrypoint-model branch from 891897d to 9fd0a12 Compare January 14, 2025 14:22
@traefiker
Copy link
Contributor

🚫 checks status: PR status: cancelled

@rtribotte rtribotte force-pushed the fix-observability-entrypoint-model branch from d413fd1 to edbe01a Compare January 14, 2025 15:01
@traefiker traefiker merged commit ad7fb8e into traefik:v3.3 Jan 14, 2025
40 checks passed
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants