-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix observability configuration on EntryPoints #11446
Merged
traefiker
merged 6 commits into
traefik:v3.3
from
rtribotte:fix-observability-entrypoint-model
Jan 14, 2025
Merged
Fix observability configuration on EntryPoints #11446
traefiker
merged 6 commits into
traefik:v3.3
from
rtribotte:fix-observability-entrypoint-model
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
kind/bug/fix
a bug fix
area/middleware/metrics
area/middleware/tracing
area/accesslogs
labels
Jan 14, 2025
rtribotte
added
status/2-needs-review
bot/light-review
decreases the number of required LGTM from 3 to 1.
and removed
status/0-needs-triage
labels
Jan 14, 2025
kevinpollet
approved these changes
Jan 14, 2025
rtribotte
force-pushed
the
fix-observability-entrypoint-model
branch
from
January 14, 2025 09:41
5b24ed4
to
1ed7a7b
Compare
juliens
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚫 checks status: PR status: cancelled |
rtribotte
force-pushed
the
fix-observability-entrypoint-model
branch
from
January 14, 2025 14:06
660882e
to
a5ced84
Compare
rtribotte
force-pushed
the
fix-observability-entrypoint-model
branch
from
January 14, 2025 14:22
891897d
to
9fd0a12
Compare
🚫 checks status: PR status: cancelled |
rtribotte
force-pushed
the
fix-observability-entrypoint-model
branch
from
January 14, 2025 15:01
d413fd1
to
edbe01a
Compare
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
status/4-merge-in-progress
labels
Jan 14, 2025
traefiker
removed
status/3-needs-merge
bot/light-review
decreases the number of required LGTM from 3 to 1.
labels
Jan 14, 2025
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the observability configuration on EntryPoints.
This configuration relies on the model mechanism for which its enablement was not yet conditioned to observability configuration on EntryPoints.
Motivation
Fixes #11444
More
Additional Notes