Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: untyped check #1020

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: untyped check #1020

merged 1 commit into from
Jan 28, 2021

Conversation

nrwiersma
Copy link
Contributor

When checking for untyped values, we can be sure at this stage that they must be a const value or already untyped. Checking for type string equality is no longer a good measure.

Fixes #1000

@nrwiersma nrwiersma requested a review from mvertes January 28, 2021 06:43
@nrwiersma nrwiersma self-assigned this Jan 28, 2021
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes mvertes added area/core bug Something isn't working labels Jan 28, 2021
@mvertes mvertes added this to the v0.9.x milestone Jan 28, 2021
@traefiker traefiker merged commit d73111c into traefik:master Jan 28, 2021
@nrwiersma nrwiersma deleted the fix-untyped-check branch January 28, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assign imported variable get type mismatch
3 participants