Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp: fix default comm clause in select #1450

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Conversation

mvertes
Copy link
Member

@mvertes mvertes commented Sep 5, 2022

Do not attempt to init a non-existent channel setting when in
default communication clause in select.

Fixes #1442.

Do not attempt to init a non-existent channel setting when in
default communication clause in select.

Fixes traefik#1442.
@mvertes mvertes added this to the v0.14.x milestone Sep 5, 2022
@mvertes mvertes requested a review from mpl September 5, 2022 18:32
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the changes to select1.go and select14.go?
They seem to run fine on my laptop without the changes.

Also I have additional questions, but they are not blocking for the merge.

interp/cfg.go Outdated Show resolved Hide resolved
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goroutine stack exceeds 1000000000-byte limit
3 participants