Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use x/tools/go/packages to significantly improve speed of extract code generation #1642

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use x/tools/go/packages to significantly improve speed of extract code generation #1642

wants to merge 10 commits into from
+47 −4

Commits on Jul 6, 2024

  1. initial implementation of x/packages based extraction; not working yet

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    e9faf21 View commit details
    Browse the repository at this point in the history

  2. handle pkg.Errors

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1c53a7f View commit details
    Browse the repository at this point in the history

  3. use Chdir and ipp for Extract and importPath

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    31998c6 View commit details
    Browse the repository at this point in the history

  4. add tools dependency

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    97b4d98 View commit details
    Browse the repository at this point in the history

  5. use pkgIdent instead of ipp

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    23ca1d5 View commit details
    Browse the repository at this point in the history

  6. use old import method for relative with manual import path; else use … 

    …new x/packages. also found minimal set of Need flags.
    @rcoreilly
    rcoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    132533f View commit details
    Browse the repository at this point in the history

  7. add comments for new Extract logic

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b61eba6 View commit details
    Browse the repository at this point in the history

  8. only actually need NeedTypes

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3d103b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'master' into x-packages

    @rcoreilly
    rcoreilly authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2521658 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into x-packages

    @kkoreilly
    kkoreilly authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    69a3c1b View commit details
    Browse the repository at this point in the history