Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk-dev] Upgrade express-fileupload from 0.0.5 to 0.4.0 #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zolamk
Copy link

@zolamk zolamk commented Jun 12, 2024

This PR was automatically created by Snyk using the credentials of a real user.


![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)

Snyk has created this PR to upgrade express-fileupload from 0.0.5 to 0.4.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 10 versions ahead of your current version.

  • The recommended version was released on 6 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Directory Traversal
SNYK-JS-ADMZIP-1065796
584 No Known Exploit
critical severity Arbitrary File Write via Archive Extraction (Zip Slip)
npm:adm-zip:20180415
584 Mature
Release notes
Package name: express-fileupload
  • 0.4.0 - 2018-01-24

    Release 0.4.0

  • 0.3.0 - 2017-10-07

    Fix for #50

    NOTE: all versions moving forward will enforce support for Node 6+

  • 0.2.0 - 2017-08-28

    Breaking Changes

    • Support for Node.js v6 and above. No longer supporting versions of Node older than 6
    • .mv() now returns a Promise when callback argument is not provided

    New Features

  • 0.1.4 - 2017-06-30

    Bugfixes

  • 0.1.3 - 2017-04-30

    Bugfixes

    • #21 safeFileName: Extensions are unexpectedly stripped out

    New Features

  • 0.1.2 - 2017-03-09

    Bugfixes

    • #16 Upload Large file

    New Features

  • 0.1.1 - 2017-02-18

    Breaking Changes

    Breaking Change 1.) No more urlencoded support

    As of v0.1.0, there is NO MORE application/x-www-form-urlencoded SUPPORT! Moving forward, express-fileupload is considered a "multipart" solution only. If you want to parse urlencoded requests, use body-parser.

    Breaking Change 2.) Support for Node v4.x.x and above now

    Usage with Node <4 is no longer supported. Use at your own risk.

    Bugfixes

    • #6 Crashes when multipart request is empty (3d72084)
    • #9 & #11 body-parser interferes with express-fileupload and vice versa (92d7ad5)
    • #19 TypeError: callback is not a function (df3df26)

    New Features

    • Unit testing and test coverage. Addresses #5 (266c10d)
    • Field array parsing (PR #20)
  • 0.1.0 - 2017-02-18

    markdown update

  • 0.0.7 - 2017-02-10

    Bugfixes

    • #17 multiple input file input doesn't work (ec6270d)
  • 0.0.6 - 2017-01-14
  • 0.0.5 - 2016-04-22
from express-fileupload GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade express-fileupload from 0.0.5 to 0.4.0.

See this package in npm:
express-fileupload

See this project in Snyk:
https://app.dev.snyk.io/org/zolamk/project/5483dab8-2f10-4b7c-8f31-19ba2bdd02e1?utm_source=github&utm_medium=referral&page=upgrade-pr
@ferreiratiago
Copy link

ferreiratiago commented Jun 18, 2024

General comment

Copy link

@ferreiratiago ferreiratiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other issues:

Issue 3 on line 15 for file package.json.

Issue Score Exploit Maturity
high severity Directory Traversal
SNYK-JS-ADMZIP-1065796
584 No Known Exploit
critical severity Arbitrary File Write via Archive Extraction (Zip Slip)
npm:adm-zip:20180415
584 Mature

package.json Outdated
@@ -25,7 +25,7 @@
"ejs-locals": "1.0.2",
"errorhandler": "1.2.0",
"express": "4.12.4",
"express-fileupload": "0.0.5",
"express-fileupload": "0.4.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 2

@@ -25,7 +25,7 @@
"ejs-locals": "1.0.2",
"errorhandler": "1.2.0",
"express": "4.12.4",
"express-fileupload": "0.0.5",
"express-fileupload": "0.6.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 3

@@ -1,4 +1,4 @@
{
z{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 4

@@ -25,7 +25,7 @@
"ejs-locals": "1.0.2",
"errorhandler": "1.2.0",
"express": "4.12.4",
"express-fileupload": "0.0.5",
"express-fileupload": "0.6.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants