Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vultr collection #14707

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Fix Vultr collection #14707

merged 2 commits into from
Mar 16, 2024

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Mar 13, 2024 •
edited
Loading

Description

Vultr role fixes

Motivation and Context

Fixes #14705

How Has This Been Tested?

Deployed a server

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@jackivanov jackivanov enabled auto-merge (squash) March 14, 2024 02:20
ret2libc
ret2libc approved these changes Mar 14, 2024
View reviewed changes
Copy link

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it works!

@jackivanov jackivanov merged commit a4a9d6d into master Mar 16, 2024
9 checks passed
@jackivanov jackivanov deleted the fix/14705 branch March 16, 2024 19:21
@matthewhall79 matthewhall79 mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR! couldn't resolve module/action 'vultr_firewall_group'.
2 participants
@jackivanov @ret2libc