config(backup_option): warning introduced in barman 2.8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you want to add the new parameter in the Otherwise, LGTM |
This commit offers to possibility to configure the `backup_options` from barman configuation. Since Barman 2.8 https://github.com/2ndquadrant-it/barman/blob/master/ChangeLog#L29 a warning is displayed if that configuration line is not set when using `rsync` backup_method.
Indeed good catch! I added a line in the README you are right. Feel free to merge when you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit offers to possibility to configure the
backup_optionsfrom barman configuation.
Since Barman 2.8
https://github.com/2ndquadrant-it/barman/blob/master/ChangeLog#L29
a warning is displayed if that configuration line is not set when
using
rsyncbackup_method.