New pg_upgrade script #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulRbr
reviewed
Dec 7, 2020
| DATABASE_NAME={{ postgres_dbname }} | ||
| DATABASE_PORT={{ postgres_new_cluster_port }} | ||
| # Output every line executed and stop on the first error | ||
| set -xe |
There was a problem hiding this comment.
Would it be problematic to fail on pipes too?
Suggested change
| set -xe | |
| set -xeo pipefail |
There was a problem hiding this comment.
Also, this options were passed from the bash command (in the first line of the file)
Could you change the command from #!/bin/bash -ex to #!/usr/bin/env bash please? (for better cross-platform compatibility)
chtitux
force-pushed
the
new-pg-upgrade
branch
from
d3072e2
to
0f73b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script needs to be tested. I was using it from outside the host, with SSH into the host.
Also, it requires to have "sudo" on it. Maybe you don't like that :)