Code tidying

trampgeek · May 13, 2024 · 15f42c2 · 15f42c2
1 parent 7c1be89
commit 15f42c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/classes/combinator_grader_outcome.php b/classes/combinator_grader_outcome.php
@@ -250,7 +250,7 @@ private function format_first_failing_test($correctcol) {
                 $n = count($row);
                 for ($i = 0; $i < $n; $i++) {
                     if ($headerrow[$i] != 'iscorrect') {
-                        $cell = htmlspecialchars($row[$i]);
+                        $cell = htmlspecialchars($row[$i], ENT_COMPAT | ENT_HTML401);
                         $error .= "{$headerrow[$i]}: <pre>$cell</pre>";
                     }
                 }

diff --git a/edit_coderunner_form.php b/edit_coderunner_form.php
@@ -548,10 +548,8 @@ public function data_preprocessing($question) {
             $question->penaltyregime = get_config('qtype_coderunner', 'default_penalty_regime');
         }
 
-        foreach (
-            ['datafiles' => 'datafile',
-                'sampleanswerattachments' => 'samplefile'] as $fileset => $filearea
-        ) {
+        $filesets = ['datafiles' => 'datafile', 'sampleanswerattachments' => 'samplefile'];
+        foreach ($filesets as $fileset => $filearea) {
             $draftid = file_get_submitted_draft_itemid($fileset);
             $options = $this->fileoptions;
             $options['subdirs'] = false;