Deprecated errors with PHP8.2 #186
Comments
|
Hi Anupama
Many thanks for the offer to fix those errors. Indeed, they are becoming a priority. I had intended to look into them myself over Christmas but got sidetracked into re-writing the Jobe server to use CodeIgniter4 (very different from the old version I locked in 10 years ago) and to ensure nginx compatibility. That job is almost done, but I'm off on two weeks' holiday from today.
Certainly I'd be delighted if you could look into those deprecation errors. I do worry a bit, though, that fixing them might prove problematic. Some of them are just a consequence of lazy programming but sometimes I've used dynamic attributes as a design pattern, e.g. when cloning a question during validation. But ... sure ... please go ahead and see what you can come up with in the way of fixes.
A collaborator in our department, Paul McKeown has done a lot of code tidying on CodeRunner recently so to minimise merge conflicts would you mind pulling the development branch of CodeRunner from github as a starting point, and issue any pull requests back to that branch so we can more easily manage the changes that you, Paul and I are doing in parallel.
Regards
Richard.
…________________________________
From: Anupama Sarjoshi ***@***.***>
Sent: Tuesday, January 16, 2024 1:37:55 AM
To: trampgeek/moodle-qtype_coderunner ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [trampgeek/moodle-qtype_coderunner] Deprecated errors with PHP8.2 (Issue #186)
Hi Richard,
Hope you are doing well!
We are seeing some of the deprecation errors related to dynamic property creation when updated to PHP8.2. Could you please let us know if its ok for us to fix those and send across a pull request? Also, probably will need to update the CI workflow to run with PHP8.1 and PHP8.2.
Some of the errors I have listed in here:
* Deprecated: Creation of dynamic property qtype_coderunner_question::$prototypeextra is deprecated in ...\workspace\ou-moodle2\question\type\questiontypebase.php on line 1015
* Deprecated: Creation of dynamic property qtype_coderunner_question::$answers is deprecated in ...\workspace\ou-moodle2\question\type\coderunner\questiontype.php on line 590
* Deprecated: Creation of dynamic property qtype_coderunner_question::$prototype is deprecated in ...\workspace\ou-moodle2\question\type\coderunner\question.php on line 998
* Deprecated: Creation of dynamic property qtype_coderunner_question::$initialisationerrormessage is deprecated in C:\Users\as38293\workspace\ou-moodle2\question\type\coderunner\question.php on line 109
Thanks,
Anupama
CC: @timhunt<https://github.com/timhunt>
—
Reply to this email directly, view it on GitHub<#186>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIM2VT7WPYR2OUW5Q4R34TYOUPKHAVCNFSM6AAAAABB3GTBSOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DCOJVGIYTCNA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
This email may be confidential and subject to legal privilege, it may not reflect the views of the University of Canterbury, and it is not guaranteed to be virus free. If you are not an intended recipient, please notify the sender immediately and erase all copies of the message and any attachments.
|
|
Sure, thanks Richard. I will have a look at these. Have a good holiday! Best wishes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Richard,
Hope you are doing well!
We are seeing some of the deprecation errors related to dynamic property creation when updated to PHP8.2. Could you please let us know if its ok for us to fix those and send across a pull request? Also, probably will need to update the CI workflow to run with PHP8.1 and PHP8.2.
Some of the errors I have listed in here:
Thanks,
Anupama
CC: @timhunt
The text was updated successfully, but these errors were encountered: