Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace Gapfiller UI breaks with adjacent gaps #196

Open
chrahe opened this issue Feb 8, 2024 · 0 comments
Open

Ace Gapfiller UI breaks with adjacent gaps #196

chrahe opened this issue Feb 8, 2024 · 0 comments

Comments

@chrahe
Copy link
Contributor

chrahe commented Feb 8, 2024

When there are two gaps in the Ace Gapfiller UI separated by a single character and the first gap is able to expand in width, the gap starts expanding into the following gap which subsequently becomes impossible to access.

The reason for this is this line.

if (other.range.start.row === this.range.start.row && other.range.start.column > this.range.end.column) {

When the first gap expands, its end column is equal to the next gap's start column, so the condition does not trigger and the other gap is not shifted right as it should be. The issue can be resolved by comparing the start columns for both ranges.

chrahe added a commit to chrahe/moodle-qtype_coderunner that referenced this issue Feb 8, 2024
chrahe added a commit to chrahe/moodle-qtype_coderunner that referenced this issue Feb 12, 2024
trampgeek pushed a commit that referenced this issue Mar 14, 2024
* fix for issue #196

* updated ui_ace_gapfiller minified versions to address issue #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant