Development - grade result cache with on/off switch for local testing #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the Coderunner settings. Just in case we want to ressurect them.
|
Thanks Paul. I merged and pulled to my own machine.
Interestingly, when I then tried to use the updated Moodle I landed on an error page, telling me that I was missing some strings relating to gradecache. I couldn't find any way out of that error page. I was able to get going again by updating version.php, so that when I reloaded the page I got thrown into the admin update-plugsin page, which cleared the cache and loaded in your new settings. I guess the moral there is always to update version.php to the current date when pushing to development (not something I'm in the habit of doing, either).
The plugin update page then nicely presented me with:
[cid:41d748d7-7856-4c04-b3a2-9ce531db953d]
Which looks nice. Thanks 🙂
Richard
…________________________________
From: Paul McKeown ***@***.***>
Sent: Wednesday, 17 July 2024 5:24 pm
To: trampgeek/moodle-qtype_coderunner ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [trampgeek/moodle-qtype_coderunner] Development - grade result cache with on/off switch for local testing (PR #215)
Hi Richard,
here is the updated grade result cache code for testing.
It has the on/off switch and doesn't cache WS requests (eg, try-it or scratchpad jobs).
Cheers,
Paul
________________________________
You can view, comment on, or merge this pull request online at:
#215
Commit Summary
* 63db0bb<63db0bb> Pre-release version of grade caching with cache read and write switches
* ad84a80<ad84a80> Result caching added for Jobe runs. It is turned off by default.
* 4e07518<4e07518> Small tweak to run_in_sandbox to keep old versions of PHP happy.
* 45ebaa3<45ebaa3> Minor wording updates for grade cache settings.
File Changes
(5 files<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files>)
* D .~lock.loadtestingresults2.ods#<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-f68db786300683cf2491a90c03b925297c9a247eb6d90b9e7790bb4471ea2570> (1)
* M classes/external/run_in_sandbox.php<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-60488f099429e27cb21c4cddf0c60edbdc2a9c48c1d18434dc6239e172501558> (3)
* M classes/jobesandbox.php<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-9091470be75c3c568e037e04faef6cd512bca78793d27661d6b27f4449b3eeb1> (38)
* M lang/en/qtype_coderunner.php<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-3f4992c797fc3fcd8b093a2722560e00b345ed56f2185a1c876017ca221f67f9> (6)
* M settings.php<https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-4092c491c25e7e19aceafbe3c49d234ce7d1eca769519197d2ccba7bde75a27e> (21)
Patch Links:
* https://github.com/trampgeek/moodle-qtype_coderunner/pull/215.patch
* https://github.com/trampgeek/moodle-qtype_coderunner/pull/215.diff
—
Reply to this email directly, view it on GitHub<#215>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIM2VQ5EOC56FPOU2IX2K3ZMX5ZZAVCNFSM6AAAAABK73WEYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTENRXG42TMOI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
This email may be confidential and subject to legal privilege, it may not reflect the views of the University of Canterbury, and it is not guaranteed to be virus free. If you are not an intended recipient, please notify the sender immediately and erase all copies of the message and any attachments.
|
|
Hi,
ah yes, I did wonder about the versioning implications but I figured you'd
know what to do there 😄
…On Wed, 17 Jul 2024, 19:50 Richard Lobb, ***@***.***> wrote:
Thanks Paul. I merged and pulled to my own machine.
Interestingly, when I then tried to use the updated Moodle I landed on an
error page, telling me that I was missing some strings relating to
gradecache. I couldn't find any way out of that error page. I was able to
get going again by updating version.php, so that when I reloaded the page I
got thrown into the admin update-plugsin page, which cleared the cache and
loaded in your new settings. I guess the moral there is always to update
version.php to the current date when pushing to development (not something
I'm in the habit of doing, either).
The plugin update page then nicely presented me with:
[cid:41d748d7-7856-4c04-b3a2-9ce531db953d]
Which looks nice. Thanks 🙂
Richard
________________________________
From: Paul McKeown ***@***.***>
Sent: Wednesday, 17 July 2024 5:24 pm
To: trampgeek/moodle-qtype_coderunner ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [trampgeek/moodle-qtype_coderunner] Development - grade result
cache with on/off switch for local testing (PR #215)
Hi Richard,
here is the updated grade result cache code for testing.
It has the on/off switch and doesn't cache WS requests (eg, try-it or
scratchpad jobs).
Cheers,
Paul
________________________________
You can view, comment on, or merge this pull request online at:
#215
Commit Summary
* 63db0bb<
63db0bb>
Pre-release version of grade caching with cache read and write switches
* ad84a80<
ad84a80>
Result caching added for Jobe runs. It is turned off by default.
* 4e07518<
4e07518>
Small tweak to run_in_sandbox to keep old versions of PHP happy.
* 45ebaa3<
45ebaa3>
Minor wording updates for grade cache settings.
File Changes
(5 files<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files>)
* D .~lock.loadtestingresults2.ods#<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-f68db786300683cf2491a90c03b925297c9a247eb6d90b9e7790bb4471ea2570>
(1)
* M classes/external/run_in_sandbox.php<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-60488f099429e27cb21c4cddf0c60edbdc2a9c48c1d18434dc6239e172501558>
(3)
* M classes/jobesandbox.php<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-9091470be75c3c568e037e04faef6cd512bca78793d27661d6b27f4449b3eeb1>
(38)
* M lang/en/qtype_coderunner.php<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-3f4992c797fc3fcd8b093a2722560e00b345ed56f2185a1c876017ca221f67f9>
(6)
* M settings.php<
https://github.com/trampgeek/moodle-qtype_coderunner/pull/215/files#diff-4092c491c25e7e19aceafbe3c49d234ce7d1eca769519197d2ccba7bde75a27e>
(21)
Patch Links:
* https://github.com/trampgeek/moodle-qtype_coderunner/pull/215.patch
* https://github.com/trampgeek/moodle-qtype_coderunner/pull/215.diff
—
Reply to this email directly, view it on GitHub<
#215>, or
unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAIM2VQ5EOC56FPOU2IX2K3ZMX5ZZAVCNFSM6AAAAABK73WEYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTENRXG42TMOI>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
This email may be confidential and subject to legal privilege, it may not
reflect the views of the University of Canterbury, and it is not guaranteed
to be virus free. If you are not an intended recipient, please notify the
sender immediately and erase all copies of the message and any attachments.
—
Reply to this email directly, view it on GitHub
<#215 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM335VFXIWILWSE6GV3YNJDZMYO2ZAVCNFSM6AAAAABK73WEYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSGY2TOOBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Richard,
here is the updated grade result cache code for testing.
It has the on/off switch and doesn't cache WS requests (eg, try-it or scratchpad jobs).
Cheers,
Paul